santhoshe447 wrote:
> I was wondering if we should let each target print the disassembly instead of
> trying to do that generically. Maybe put it into Plugins/Instruction and
> provide some helper functions. Do you think that would be much larger effort?
That approach would work, but I think it would be a much larger refactoring
effort.
- The current implementation already handles most instruction formats
generically. The main exception is VLIW targets (e.g. Hexagon), where
instruction grouping and presentation differ from the common case.
- For readability in the interactive view, we display multi-instruction VLIW
packets enclosed in {}.
- For that reason, I'd prefer to keep the common implementation for most
targets and only separate the presentation logic for VLIW and non-VLIW output.
This keeps the implementation simple, avoids further code duplication, and
minimizes maintenance overhead.
https://github.com/llvm/llvm-project/pull/207359
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
