JDevlieghere wrote: > I'll be candid: seeing this reimplemented and rebased without a heads-up was > hard, and I only just learned I'd been added as a reviewer on the new PRs; > nobody actually reached out. I first published this work in 2020 (D78801); it > went unreviewed after a few iterations. I rebased it here in #77949 in early > 2024, addressed the feedback, and then it simply stopped being reviewed for > two years. It didn't stall because I walked away. Some of the same reviewers > were later involved in the reimplementation; one noting mine was "unlikely to > get merged by the authors." A heads-up before rebuilding an open, > still-maintained patch would have been the decent thing to do. > > I still care about Wasm debugging in LLDB and I'm glad it's landing. If it's > useful, I'm happy to help with what's left.
Paolo reached out to me over email as well, and I replied there before I saw this comment. Since this thread is public and I think it matters for the community, I want to summarize what I said. It was never my intention to leave @paolosevMSFT out, and I added him as a reviewer and tagged him [in](https://github.com/llvm/llvm-project/pull/151010) [the](https://github.com/llvm/llvm-project/pull/151056) [initial](https://github.com/llvm/llvm-project/pull/153093) [PRs](https://github.com/llvm/llvm-project/pull/150143). I mistook the lack of engagement as a sign this wasn't something he was still actively working on, and in hindsight this could've been avoided by reaching out to him directly over e-mail. That's on me and I'm sorry. All the work that has landed since then is built on the foundation Paolo built and I'm tremendously grateful for it, and I've done my best to acknowledge that and credit him along the way. We clearly both care about Wasm debugging in LLDB and I've suggested syncing up to discuss how we can collaborate going forward. Thanks again for all the work you put into this! https://github.com/llvm/llvm-project/pull/77949 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
