https://github.com/Nerixyz approved this pull request.
This looks good to me now. I think it should be noted that we only need to do this when attaching to a process. We notice this in lldb-dap when launching in a terminal, because that will attach to the process. The documentation for [`DebugActiveProcess`](https://learn.microsoft.com/en-us/windows/win32/api/debugapi/nf-debugapi-debugactiveprocess) also mentions this: > After all of this is done, the system resumes all threads in the process. > When the first thread in the process resumes, it executes a breakpoint > instruction that causes an EXCEPTION_DEBUG_EVENT debugging event to be sent > to the debugger. All future debugging events are sent to the debugger by > using the normal mechanism and rules. https://github.com/llvm/llvm-project/pull/208233 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
