https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/210989
This reverts commit 5a19a3a4b9915d19fff1b8298e723ee2b24ebc6a. To fix a failure with MinGW (https://github.com/llvm/llvm-project/pull/209464#issuecomment-5034222807). >From 94b6b81464ba47c58ceb2eb9e875a4c264fa208c Mon Sep 17 00:00:00 2001 From: Nerixyz <[email protected]> Date: Tue, 21 Jul 2026 15:14:05 +0200 Subject: [PATCH] Revert "[lldb][Windows] Only embed Python home in Debug config (#209464)" This reverts commit 5a19a3a4b9915d19fff1b8298e723ee2b24ebc6a. --- lldb/cmake/modules/LLDBConfig.cmake | 2 +- lldb/docs/resources/build.md | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/lldb/cmake/modules/LLDBConfig.cmake b/lldb/cmake/modules/LLDBConfig.cmake index 5f239139bab6f..e086aaf5d3632 100644 --- a/lldb/cmake/modules/LLDBConfig.cmake +++ b/lldb/cmake/modules/LLDBConfig.cmake @@ -198,7 +198,7 @@ endif() option(LLDB_ENABLE_DYNAMIC_SCRIPTINTERPRETERS "Build the script interpreter plugins as shared libraries" ${default_enable_dynamic_scriptinterpreters}) if (LLDB_ENABLE_PYTHON) - if(CMAKE_SYSTEM_NAME MATCHES "Windows" AND CMAKE_BUILD_TYPE STREQUAL "Debug") + if(CMAKE_SYSTEM_NAME MATCHES "Windows") set(default_embed_python_home ON) else() set(default_embed_python_home OFF) diff --git a/lldb/docs/resources/build.md b/lldb/docs/resources/build.md index 759acf9056203..2ad5fb8c91bda 100644 --- a/lldb/docs/resources/build.md +++ b/lldb/docs/resources/build.md @@ -282,15 +282,15 @@ are commonly used on Windows. crash, rather than having to reproduce a failure or use a crash dump. - `PYTHON_HOME` (Required): Path to the folder where the Python distribution is installed. For example, `C:\Python35`. -- `LLDB_EMBED_PYTHON_HOME` (Default=1 on Windows in the Debug configuration): - When this is 1, LLDB will bind statically to the location specified in the - `PYTHON_HOME` CMake variable, ignoring any value of `PYTHONHOME` set in the - environment. This is most useful for developers who simply want to run LLDB - after they build it. If you wish to move a build of LLDB to a different - machine where Python will be in a different location, setting - `LLDB_EMBED_PYTHON_HOME` to 0 will cause Python to use its default mechanism - for finding the python installation at runtime (looking for installed - Pythons, or using the `PYTHONHOME` environment variable if it is specified). +- `LLDB_EMBED_PYTHON_HOME` (Default=1 on Windows): When this is 1, LLDB will bind + statically to the location specified in the `PYTHON_HOME` CMake variable, + ignoring any value of `PYTHONHOME` set in the environment. This is most + useful for developers who simply want to run LLDB after they build it. If you + wish to move a build of LLDB to a different machine where Python will be in a + different location, setting `LLDB_EMBED_PYTHON_HOME` to 0 will cause + Python to use its default mechanism for finding the python installation at + runtime (looking for installed Pythons, or using the `PYTHONHOME` + environment variable if it is specified). Sample command line: _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
