aurore-poirier wrote:

> I think this should be handled correctly in `Symbol::GetLoadAddress`, or else 
> we'll have other callers that will misbehave with an absolute VA in a Symbol, 
> like this.

As far as i know, ELF specs do not guarantee that absolute symbols are valid 
address (and that's actually what f0697d7c3fb5296cfec1718206aceb77b7ca9ab8 is 
about). I am afraid that serving potentially invalid addresses with 
`Symbol::GetLoadAddress` could break quite a lot of callers. However, we might 
want to add a new getter which still returns the value when the symbol is 
absolute, and use this one when sending `qSymbol` GDB packets

https://github.com/llvm/llvm-project/pull/200134
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to