================
@@ -14,7 +14,7 @@
 #include "ScriptedInterface.h"
 
 namespace lldb_private {
-class ScriptedHookInterface : public ScriptedInterface {
+class ScriptedHookInterface : virtual public ScriptedInterface {
----------------
jimingham wrote:

That talk didn't in fact mention that both ScriptedInterfaceBreakpoint and 
ScriptedInterfacePython (which seems more like a helper than an interface per 
se) both inherit from ScriptedInterface... 
But that's not the main point.  I couldn't see anything in this patch that 
would require you have a diamond graph rather than two copies of the 
ScriptedInterface data.  What required that?

https://github.com/llvm/llvm-project/pull/198153
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to