================
@@ -3119,11 +3119,13 @@ Target::ReadInstructions(const Address &start_addr, 
uint32_t count,
       ReadMemory(start_addr, data.GetBytes(), data.GetByteSize(), error,
                  force_live_memory, &load_addr);
 
-  if (error.Fail())
+  if (error.Fail()) {
+    if (error.AsCString(/*default_error_str=*/nullptr))
----------------
da-viper wrote:

I separated it because, we would have to allocate twice(since it takes a 
char*). Once for the creating the default value and the other when assigning it 
to the internal string. we also lose the `llvm::Error` type to string. 

https://github.com/llvm/llvm-project/pull/212503
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to