satyajanga wrote: > LGTM, matches the new error-message style from #156774. > > Some tests, like `TestTraceDumpInfo.testErrorMessages`, don't require intel > pt. I get the same error message on my Mac, > > ``` > (lldb) thread trace dump info > error: process is not being traced > ``` > > so don't have to skip this test if the host doesn't have intel pt feature.
Thank you for the review and suggestions. I agree about the `TestTraceDumpInfo.testErrorMessages` test. However I would like to do it as a followup. https://github.com/llvm/llvm-project/pull/212372 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
