Author: satyanarayana reddy janga Date: 2026-07-28T09:51:06-06:00 New Revision: 9a7284cedd2c75a7d53e44a49bfa03bfc0c27cae
URL: https://github.com/llvm/llvm-project/commit/9a7284cedd2c75a7d53e44a49bfa03bfc0c27cae DIFF: https://github.com/llvm/llvm-project/commit/9a7284cedd2c75a7d53e44a49bfa03bfc0c27cae.diff LOG: [lldb] Fix trace test assertions after error-message style change (#212372) Commit 820f4402745d ([lldb] Correct style of error messages, #156774) changed the "process is not being traced" error emitted by CommandObject::CheckRequirements from "Process is not being traced." to "process is not being traced" (lowercase, no trailing period), but did not update the trace API tests that assert on that string. These tests only run when the intel-pt plugin is enabled and the host has Intel PT support (TraceIntelPTTestCaseBase.setUp skips otherwise), so they are skipped on most buildbots and the stale assertions went unnoticed. Update all five affected tests to match the new message. Added: Modified: lldb/test/API/commands/trace/TestTraceDumpInfo.py lldb/test/API/commands/trace/TestTraceDumpInstructions.py lldb/test/API/commands/trace/TestTraceExport.py lldb/test/API/commands/trace/TestTraceSave.py lldb/test/API/commands/trace/TestTraceStartStop.py Removed: ################################################################################ diff --git a/lldb/test/API/commands/trace/TestTraceDumpInfo.py b/lldb/test/API/commands/trace/TestTraceDumpInfo.py index 52449631f6aa9..d63884067a2cf 100644 --- a/lldb/test/API/commands/trace/TestTraceDumpInfo.py +++ b/lldb/test/API/commands/trace/TestTraceDumpInfo.py @@ -34,7 +34,7 @@ def testErrorMessages(self): self.expect( "thread trace dump info", - substrs=["error: Process is not being traced"], + substrs=["error: process is not being traced"], error=True, ) diff --git a/lldb/test/API/commands/trace/TestTraceDumpInstructions.py b/lldb/test/API/commands/trace/TestTraceDumpInstructions.py index fa4d38f01192c..5085a4335d9a1 100644 --- a/lldb/test/API/commands/trace/TestTraceDumpInstructions.py +++ b/lldb/test/API/commands/trace/TestTraceDumpInstructions.py @@ -32,7 +32,7 @@ def testErrorMessages(self): self.expect( "thread trace dump instructions", - substrs=["error: Process is not being traced"], + substrs=["error: process is not being traced"], error=True, ) diff --git a/lldb/test/API/commands/trace/TestTraceExport.py b/lldb/test/API/commands/trace/TestTraceExport.py index a6ca736d3c5a4..1aff7674ac6f6 100644 --- a/lldb/test/API/commands/trace/TestTraceExport.py +++ b/lldb/test/API/commands/trace/TestTraceExport.py @@ -38,7 +38,7 @@ def testErrorMessages(self): self.expect( f"thread trace export ctf --file {ctf_test_file}", - substrs=["error: Process is not being traced"], + substrs=["error: process is not being traced"], error=True, ) diff --git a/lldb/test/API/commands/trace/TestTraceSave.py b/lldb/test/API/commands/trace/TestTraceSave.py index 4e3c70695bcee..776a0b199361c 100644 --- a/lldb/test/API/commands/trace/TestTraceSave.py +++ b/lldb/test/API/commands/trace/TestTraceSave.py @@ -40,7 +40,7 @@ def testErrorMessages(self): self.expect("run") self.expect( - "trace save", substrs=["error: Process is not being traced"], error=True + "trace save", substrs=["error: process is not being traced"], error=True ) @skipIfNoIntelPT diff --git a/lldb/test/API/commands/trace/TestTraceStartStop.py b/lldb/test/API/commands/trace/TestTraceStartStop.py index 8f882eb5d974b..e934b4d514f7f 100644 --- a/lldb/test/API/commands/trace/TestTraceStartStop.py +++ b/lldb/test/API/commands/trace/TestTraceStartStop.py @@ -220,7 +220,7 @@ def testStartStopLiveThreads(self): self.expect( "thread trace stop", error=True, - substrs=["error: Process is not being traced"], + substrs=["error: process is not being traced"], ) # the help command should be the intel-pt one now _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
