https://github.com/felipepiovezan approved this pull request.
LGTM! Please be careful when merging: the PR message is outdated (the commit message seems correct). When you merge, have a look at what GitHub shows as the preview for the final message: will it use the PR description, or the commit message? One small note about the llvm convention here: while I personally prefer the squash+force push approach, this is not the convention in the LLVM repo. Here, the prescribed approach is to make a change and then "git commit --fixup", so that reviewers can inspect how feedback was addressed. (Github is configured to squash everything upon merging) https://github.com/llvm/llvm-project/pull/208347 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
