qiyao wrote: > These comments in this PR are way too verbose both in general and by LLVM's > standards. Comments should describe general principles, not concrete examples > or narrate a particular bug fix that prompted the change. The latter belongs > in the commit message. They also definitely shouldn't be duplicated three > times across the file.
I pushed a new commit to simplify the comments. Additionally, does it make sense to add a file-local/private template helper `GetUInt<T>`, and make the existing public `GetU16/32/64` call it? https://github.com/llvm/llvm-project/pull/213038 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
