llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) <details> <summary>Changes</summary> This is a follow up to https://github.com/llvm/llvm-project/pull/212753 to convert the `commands` tests to use the `@<!-- -->require` decorator. --- Patch is 40.22 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/213465.diff 50 Files Affected: - (modified) lldb/test/API/commands/add-dsym/uuid/TestAddDsymCommand.py (+1-1) - (modified) lldb/test/API/commands/command/language/TestFrameLanguageCommands.py (+1-1) - (modified) lldb/test/API/commands/dwim-print/TestDWIMPrint.py (+1-1) - (modified) lldb/test/API/commands/dwim-print/objc/TestDWIMPrintObjC.py (+2-2) - (modified) lldb/test/API/commands/expression/anonymous-struct/TestCallUserAnonTypedef.py (+1-1) - (modified) lldb/test/API/commands/expression/argument_passing_restrictions/TestArgumentPassingRestrictions.py (+1-1) - (modified) lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py (+1-1) - (modified) lldb/test/API/commands/expression/call-function/TestCallStopAndContinue.py (+1-1) - (modified) lldb/test/API/commands/expression/call-function/TestCallUserDefinedFunction.py (+1-1) - (modified) lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py (+2-2) - (modified) lldb/test/API/commands/expression/class_template_specialization_empty_pack/TestClassTemplateSpecializationParametersHandling.py (+1-1) - (modified) lldb/test/API/commands/expression/context-object/TestContextObject.py (+1-1) - (modified) lldb/test/API/commands/expression/expr-with-fork/TestExprWithFork.py (+16-16) - (modified) lldb/test/API/commands/expression/expr_inside_lambda/TestExprInsideLambdas.py (+1-1) - (modified) lldb/test/API/commands/expression/formatters/TestFormatters.py (+1-1) - (modified) lldb/test/API/commands/expression/inline-namespace/TestInlineNamespace.py (+1-1) - (modified) lldb/test/API/commands/expression/namespace-alias/TestInlineNamespaceAlias.py (+1-1) - (modified) lldb/test/API/commands/expression/persistent_types/TestNestedPersistentTypes.py (+1-1) - (modified) lldb/test/API/commands/expression/persistent_types/TestPersistentTypes.py (+1-1) - (modified) lldb/test/API/commands/expression/po_persistent_result/TestPoPersistentResult.py (+3-3) - (modified) lldb/test/API/commands/expression/pr35310/TestExprsBug35310.py (+1-1) - (modified) lldb/test/API/commands/expression/radar_9531204/TestPrintfAfterUp.py (+1-1) - (modified) lldb/test/API/commands/expression/radar_9673664/TestExprHelpExamples.py (+1-1) - (modified) lldb/test/API/commands/expression/result_numbering/TestResultNumbering.py (+1-1) - (modified) lldb/test/API/commands/expression/test/TestExprs.py (+1-1) - (modified) lldb/test/API/commands/expression/timeout/TestCallWithTimeout.py (+1-1) - (modified) lldb/test/API/commands/expression/unwind_expression/TestUnwindExpression.py (+1-1) - (modified) lldb/test/API/commands/expression/weak_symbols/TestWeakSymbols.py (+1-1) - (modified) lldb/test/API/commands/expression/xvalue/TestXValuePrinting.py (+1-1) - (modified) lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py (+1-1) - (modified) lldb/test/API/commands/frame/var/TestFrameVar.py (+2-2) - (modified) lldb/test/API/commands/frame/var/direct-ivar/objc/TestFrameVarDirectIvarObjC.py (+2-2) - (modified) lldb/test/API/commands/frame/var/direct-ivar/objcpp/TestFrameVarDirectIvarObjCPlusPlus.py (+3-3) - (modified) lldb/test/API/commands/platform/basic/TestPlatformPython.py (+1-1) - (modified) lldb/test/API/commands/platform/connect/TestPlatformConnect.py (+1-1) - (modified) lldb/test/API/commands/platform/launchgdbserver/TestPlatformLaunchGDBServer.py (+1-1) - (modified) lldb/test/API/commands/platform/process/list/TestProcessList.py (+1-1) - (modified) lldb/test/API/commands/platform/sdk/TestPlatformSDK.py (+1-1) - (modified) lldb/test/API/commands/process/attach/TestProcessAttach.py (+1-1) - (modified) lldb/test/API/commands/process/attach/attach_denied/TestAttachDenied.py (+2-2) - (modified) lldb/test/API/commands/process/handle/TestProcessHandle.py (+1-1) - (modified) lldb/test/API/commands/process/launch-with-shellexpand/TestLaunchWithShellExpand.py (+1-1) - (modified) lldb/test/API/commands/process/reverse-continue/TestReverseContinue.py (+1-1) - (modified) lldb/test/API/commands/protocol/TestMCPUnixSocket.py (+1-1) - (modified) lldb/test/API/commands/register/register_command/TestRegisters.py (+1-1) - (modified) lldb/test/API/commands/statistics/basic/TestStats.py (+3-3) - (modified) lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py (+1-1) - (modified) lldb/test/API/commands/target/dump-pcm-info/TestDumpPCMInfo.py (+1-1) - (modified) lldb/test/API/commands/target/dump-separate-debug-info/oso/TestDumpOso.py (+5-5) - (modified) lldb/test/API/commands/target/stop-hooks/TestStopHooks.py (+1-1) ``````````diff diff --git a/lldb/test/API/commands/add-dsym/uuid/TestAddDsymCommand.py b/lldb/test/API/commands/add-dsym/uuid/TestAddDsymCommand.py index ba03f397277fc..f9490e40298a2 100644 --- a/lldb/test/API/commands/add-dsym/uuid/TestAddDsymCommand.py +++ b/lldb/test/API/commands/add-dsym/uuid/TestAddDsymCommand.py @@ -9,7 +9,7 @@ from lldbsuite.test import lldbutil -@skipUnlessDarwin +@requireDarwin class AddDsymCommandCase(TestBase): SHARED_BUILD_TESTCASE = False diff --git a/lldb/test/API/commands/command/language/TestFrameLanguageCommands.py b/lldb/test/API/commands/command/language/TestFrameLanguageCommands.py index b02ffd079ebd2..f8e6c17ae34d7 100644 --- a/lldb/test/API/commands/command/language/TestFrameLanguageCommands.py +++ b/lldb/test/API/commands/command/language/TestFrameLanguageCommands.py @@ -5,7 +5,7 @@ class TestCase(TestBase): - @skipUnlessDarwin + @requireDarwin def test(self): self.build() _, _, thread, _ = lldbutil.run_to_source_breakpoint( diff --git a/lldb/test/API/commands/dwim-print/TestDWIMPrint.py b/lldb/test/API/commands/dwim-print/TestDWIMPrint.py index 68b93d4a445ab..a5b051ef517f1 100644 --- a/lldb/test/API/commands/dwim-print/TestDWIMPrint.py +++ b/lldb/test/API/commands/dwim-print/TestDWIMPrint.py @@ -9,7 +9,7 @@ import lldbsuite.test.lldbutil as lldbutil -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class TestCase(TestBase): def _run_cmd(self, cmd: str) -> str: """Run the given lldb command and return its output.""" diff --git a/lldb/test/API/commands/dwim-print/objc/TestDWIMPrintObjC.py b/lldb/test/API/commands/dwim-print/objc/TestDWIMPrintObjC.py index 616d049459ab9..a25a192527293 100644 --- a/lldb/test/API/commands/dwim-print/objc/TestDWIMPrintObjC.py +++ b/lldb/test/API/commands/dwim-print/objc/TestDWIMPrintObjC.py @@ -9,7 +9,7 @@ class TestCase(TestBase): - @skipUnlessDarwin + @requireDarwin def test(self): self.build() lldbutil.run_to_source_breakpoint(self, "break here", lldb.SBFileSpec("main.m")) @@ -18,7 +18,7 @@ def test(self): "dwim-print parent.child", patterns=[r'_name = 0x[0-9a-f]+ @"Seven"'] ) - @skipUnlessDarwin + @requireDarwin def test_with_summary(self): self.build() lldbutil.run_to_source_breakpoint(self, "break here", lldb.SBFileSpec("main.m")) diff --git a/lldb/test/API/commands/expression/anonymous-struct/TestCallUserAnonTypedef.py b/lldb/test/API/commands/expression/anonymous-struct/TestCallUserAnonTypedef.py index fd2c1c50a08d9..a2b2134a32330 100644 --- a/lldb/test/API/commands/expression/anonymous-struct/TestCallUserAnonTypedef.py +++ b/lldb/test/API/commands/expression/anonymous-struct/TestCallUserAnonTypedef.py @@ -13,7 +13,7 @@ from lldbsuite.test import lldbutil -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class TestExprLookupAnonStructTypedef(TestBase): def test(self): """Test typedeffed untagged struct arguments for function call expressions""" diff --git a/lldb/test/API/commands/expression/argument_passing_restrictions/TestArgumentPassingRestrictions.py b/lldb/test/API/commands/expression/argument_passing_restrictions/TestArgumentPassingRestrictions.py index 526bfb27ce8ac..38115a76e4b91 100644 --- a/lldb/test/API/commands/expression/argument_passing_restrictions/TestArgumentPassingRestrictions.py +++ b/lldb/test/API/commands/expression/argument_passing_restrictions/TestArgumentPassingRestrictions.py @@ -15,7 +15,7 @@ from lldbsuite.test import lldbutil -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class TestArgumentPassingRestrictions(TestBase): @skipIf(compiler="clang", compiler_version=["<", "7.0"]) def test_argument_passing_restrictions(self): diff --git a/lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py b/lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py index 847839aec0be1..24da3287d99dd 100644 --- a/lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py +++ b/lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py @@ -8,7 +8,7 @@ from lldbsuite.test import lldbutil -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class ExprCommandCallFunctionTestCase(TestBase): @expectedFailureAll( compiler="icc", bugnumber="llvm.org/pr14437, fails with ICC 13.1" diff --git a/lldb/test/API/commands/expression/call-function/TestCallStopAndContinue.py b/lldb/test/API/commands/expression/call-function/TestCallStopAndContinue.py index 24529d02132ba..a71de3dd7d9b7 100644 --- a/lldb/test/API/commands/expression/call-function/TestCallStopAndContinue.py +++ b/lldb/test/API/commands/expression/call-function/TestCallStopAndContinue.py @@ -8,7 +8,7 @@ from lldbsuite.test import lldbutil -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class ExprCommandCallStopContinueTestCase(TestBase): def setUp(self): # Call super's setUp(). diff --git a/lldb/test/API/commands/expression/call-function/TestCallUserDefinedFunction.py b/lldb/test/API/commands/expression/call-function/TestCallUserDefinedFunction.py index 0ce0585953541..10687557cc017 100644 --- a/lldb/test/API/commands/expression/call-function/TestCallUserDefinedFunction.py +++ b/lldb/test/API/commands/expression/call-function/TestCallUserDefinedFunction.py @@ -13,7 +13,7 @@ from lldbsuite.test import lldbutil -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class ExprCommandCallUserDefinedFunction(TestBase): def test(self): """Test return values of user defined function calls.""" diff --git a/lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py b/lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py index 54b0ba9c191d4..2597d310c59d1 100644 --- a/lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py +++ b/lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py @@ -9,7 +9,7 @@ from lldbsuite.test import lldbutil -@skipIfNoSignals +@requireSignals class ExprCommandThatRestartsTestCase(TestBase): NO_DEBUG_INFO_TESTCASE = True @@ -21,7 +21,7 @@ def setUp(self): self.main_source_spec = lldb.SBFileSpec(self.main_source) @skipIfDarwin # llvm.org/pr19246: intermittent failure - @skipIfWindows # Test relies on signals, unsupported on Windows + @requireNotWindows # Test relies on signals, unsupported on Windows @expectedFlakeyAndroid(bugnumber="llvm.org/pr19246") @expectedFlakeyNetBSD def test(self): diff --git a/lldb/test/API/commands/expression/class_template_specialization_empty_pack/TestClassTemplateSpecializationParametersHandling.py b/lldb/test/API/commands/expression/class_template_specialization_empty_pack/TestClassTemplateSpecializationParametersHandling.py index b378e9829869b..0ccd832bd5991 100644 --- a/lldb/test/API/commands/expression/class_template_specialization_empty_pack/TestClassTemplateSpecializationParametersHandling.py +++ b/lldb/test/API/commands/expression/class_template_specialization_empty_pack/TestClassTemplateSpecializationParametersHandling.py @@ -11,7 +11,7 @@ from lldbsuite.test import lldbutil -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class TestClassTemplateSpecializationParametersHandling(TestBase): def test_class_template_specialization(self): self.build() diff --git a/lldb/test/API/commands/expression/context-object/TestContextObject.py b/lldb/test/API/commands/expression/context-object/TestContextObject.py index 0d9b1161f33a5..34a2686c102fb 100644 --- a/lldb/test/API/commands/expression/context-object/TestContextObject.py +++ b/lldb/test/API/commands/expression/context-object/TestContextObject.py @@ -8,7 +8,7 @@ from lldbsuite.test.lldbtest import * -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class ContextObjectTestCase(TestBase): def test_context_object(self): """Tests expression evaluation in context of an object.""" diff --git a/lldb/test/API/commands/expression/expr-with-fork/TestExprWithFork.py b/lldb/test/API/commands/expression/expr-with-fork/TestExprWithFork.py index 478bfe491125a..411132370eb45 100644 --- a/lldb/test/API/commands/expression/expr-with-fork/TestExprWithFork.py +++ b/lldb/test/API/commands/expression/expr-with-fork/TestExprWithFork.py @@ -18,7 +18,7 @@ class ExprWithForkTestCase(TestBase): # --- Basic expression evaluation across fork/vfork --- - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_fork(self): """Test that expression evaluation succeeds when the expression calls fork().""" @@ -31,7 +31,7 @@ def test_expr_with_fork(self): "fork_and_return(42, false)", result_type="int", result_value="42" ) - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_vfork(self): """Test that expression evaluation succeeds when the expression calls vfork().""" @@ -44,7 +44,7 @@ def test_expr_with_vfork(self): "fork_and_return(42, true)", result_type="int", result_value="42" ) - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_fork_trap(self): """Test that expression evaluation handles a child process that triggers a SIGTRAP.""" @@ -66,7 +66,7 @@ def test_expr_with_fork_trap(self): # --- follow-fork-mode child override during expression evaluation --- - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_fork_follow_child(self): """Test that expression evaluation succeeds with follow-fork-mode child.""" @@ -87,7 +87,7 @@ def test_expr_with_fork_follow_child(self): # Verify we are still debugging the original process. self.assertEqual(process.GetProcessID(), original_pid) - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_vfork_follow_child(self): """Test that expression evaluation succeeds with vfork and follow-fork-mode child.""" @@ -107,7 +107,7 @@ def test_expr_with_vfork_follow_child(self): # --- stop-on-fork: fork interrupts expression immediately --- - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_fork_stop_on_fork(self): """Test that stop-on-fork interrupts expression evaluation on fork.""" @@ -126,7 +126,7 @@ def test_expr_with_fork_stop_on_fork(self): # The expression should be interrupted due to the fork. self.assertTrue(value.GetError().Fail()) - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_fork_stop_on_fork_process_state(self): """Test that process state is valid after stop-on-fork interrupts on fork.""" @@ -150,7 +150,7 @@ def test_expr_with_fork_stop_on_fork_process_state(self): # --- stop-on-fork with vfork: deferred to vforkdone --- - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_vfork_stop_on_fork(self): """Test that stop-on-fork with vfork defers to vforkdone and interrupts.""" @@ -170,7 +170,7 @@ def test_expr_with_vfork_stop_on_fork(self): # vfork) because stop-on-fork is set. self.assertTrue(value.GetError().Fail()) - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_vfork_stop_on_fork_process_state(self): """Test that process state is clean after vfork stop-on-fork interruption. @@ -196,7 +196,7 @@ def test_expr_with_vfork_stop_on_fork_process_state(self): self.assertEqual(process.GetProcessID(), original_pid) self.assertEqual(process.GetState(), lldb.eStateStopped) - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_vfork_stop_on_fork_breakpoints_work(self): """Test that breakpoints are functional after vfork stop-on-fork. @@ -226,7 +226,7 @@ def test_expr_with_vfork_stop_on_fork_breakpoints_work(self): # --- stop-on-fork=false (default): no interruption --- - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_fork_stop_on_fork_false(self): """Test that stop-on-fork=false allows fork expression to complete.""" @@ -246,7 +246,7 @@ def test_expr_with_fork_stop_on_fork_false(self): self.assertSuccess(value.GetError()) self.assertEqual(value.GetValueAsSigned(), 42) - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_vfork_stop_on_fork_false(self): """Test that stop-on-fork=false allows vfork expression to complete.""" @@ -285,7 +285,7 @@ def test_stop_on_fork_set_get(self): # --- stop-on-fork with follow-fork-mode child --- - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_fork_stop_on_fork_follow_child(self): """Test stop-on-fork + follow-child: expression interrupted, still on parent.""" @@ -309,7 +309,7 @@ def test_expr_with_fork_stop_on_fork_follow_child(self): self.assertTrue(value.GetError().Fail()) self.assertEqual(process.GetProcessID(), original_pid) - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_with_vfork_stop_on_fork_follow_child(self): """Test stop-on-fork + vfork + follow-child: interrupted at vforkdone, still on parent.""" @@ -335,7 +335,7 @@ def test_expr_with_vfork_stop_on_fork_follow_child(self): # --- concurrent fork on another thread during expression --- - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_concurrent_fork_other_thread(self): """Test that a fork on another thread during expression is handled correctly. @@ -373,7 +373,7 @@ def test_expr_concurrent_fork_other_thread(self): # Breakpoints should still be functional. self.expect_expr("x", result_type="int", result_value="42") - @skipIfWindows + @requirePOSIX @add_test_categories(["fork"]) def test_expr_concurrent_fork_other_thread_follow_child(self): """Test that follow-fork-mode child is overridden during expression evaluation. diff --git a/lldb/test/API/commands/expression/expr_inside_lambda/TestExprInsideLambdas.py b/lldb/test/API/commands/expression/expr_inside_lambda/TestExprInsideLambdas.py index f284dbc206b65..85a76c856800a 100644 --- a/lldb/test/API/commands/expression/expr_inside_lambda/TestExprInsideLambdas.py +++ b/lldb/test/API/commands/expression/expr_inside_lambda/TestExprInsideLambdas.py @@ -10,7 +10,7 @@ from lldbsuite.test.lldbtest import * -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class ExprInsideLambdaTestCase(TestBase): TEST_WITH_PDB_DEBUG_INFO = True SHARED_BUILD_TESTCASE = False diff --git a/lldb/test/API/commands/expression/formatters/TestFormatters.py b/lldb/test/API/commands/expression/formatters/TestFormatters.py index f520c408af171..e2744564fb647 100644 --- a/lldb/test/API/commands/expression/formatters/TestFormatters.py +++ b/lldb/test/API/commands/expression/formatters/TestFormatters.py @@ -9,7 +9,7 @@ from lldbsuite.test import lldbutil -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class ExprFormattersTestCase(TestBase): def setUp(self): # Call super's setUp(). diff --git a/lldb/test/API/commands/expression/inline-namespace/TestInlineNamespace.py b/lldb/test/API/commands/expression/inline-namespace/TestInlineNamespace.py index a2d6eef63c1a5..eee218faa6b8c 100644 --- a/lldb/test/API/commands/expression/inline-namespace/TestInlineNamespace.py +++ b/lldb/test/API/commands/expression/inline-namespace/TestInlineNamespace.py @@ -9,7 +9,7 @@ from lldbsuite.test import lldbutil -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class TestInlineNamespace(TestBase): def test(self): self.build() diff --git a/lldb/test/API/commands/expression/namespace-alias/TestInlineNamespaceAlias.py b/lldb/test/API/commands/expression/namespace-alias/TestInlineNamespaceAlias.py index eede597a57fca..765fe918d4241 100644 --- a/lldb/test/API/commands/expression/namespace-alias/TestInlineNamespaceAlias.py +++ b/lldb/test/API/commands/expression/namespace-alias/TestInlineNamespaceAlias.py @@ -11,7 +11,7 @@ from lldbsuite.test import lldbutil -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class TestInlineNamespace(TestBase): @skipIf(compiler="clang", compiler_version=["<", "16.0"]) def test(self): diff --git a/lldb/test/API/commands/expression/persistent_types/TestNestedPersistentTypes.py b/lldb/test/API/commands/expression/persistent_types/TestNestedPersistentTypes.py index fc85305ff32cf..39d01f4925e4b 100644 --- a/lldb/test/API/commands/expression/persistent_types/TestNestedPersistentTypes.py +++ b/lldb/test/API/commands/expression/persistent_types/TestNestedPersistentTypes.py @@ -9,7 +9,7 @@ from lldbsuite.test import lldbutil -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class NestedPersistentTypesTestCase(TestBase): def test_persistent_types(self): """Test that nested persistent types work.""" diff --git a/lldb/test/API/commands/expression/persistent_types/TestPersistentTypes.py b/lldb/test/API/commands/expression/persistent_types/TestPersistentTypes.py index 7defad224fab8..463ddbe8b5bcb 100644 --- a/lldb/test/API/commands/expression/persistent_types/TestPersistentTypes.py +++ b/lldb/test/API/commands/expression/persistent_types/TestPersistentTypes.py @@ -9,7 +9,7 @@ from lldbsuite.test import lldbutil -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class PersistenttypesTestCase(TestBase): def test_persistent_types(self): """Test that lldb persistent types works correctly.""" diff --git a/lldb/test/API/commands/expression/po_persistent_result/TestPoPersistentResult.py b/lldb/test/API/commands/expression/po_persistent_result/TestPoPersistentResult.py index a5b48a1bf3972..8f4bba421579d 100644 --- a/lldb/test/API/commands/expression/po_persistent_result/TestPoPersistentResult.py +++ b/lldb/test/API/commands/expression/po_persistent_result/TestPoPersistentResult.py @@ -14,12 +14,12 @@ def setUp(self): self.build() lldbutil.run_to_source_breakpoint(self, "break here", lldb.SBFileSpec("main.m")) - @skipUnlessDarwin + @requireDarwin def test_po_does_not_print_persistent_result(self): """Test `po` doesn't advertise a persistent result variable.""" self.expect("po obj", matching=False, substrs=["$0 = "]) - @skipUnlessDarwin + @requireDarwin def test_po_does_not_keep_persistent_result(self): """Test `po` doesn't leak a persistent result variable.""" self.expect("po obj") @@ -28,7 +28,7 @@ def test_po_does_not_keep_persistent_result(self): self.expect("expression $0", error=True) self.expect("expression obj", substrs=["$0 = "]) - @skipUnlessDarwin + @requireDarwin def test_expression_description_verbosity(self): """Test printing object description _and_ opt-in to persistent results.""" self.expect("expression -O -vfull -- obj", substrs=["$0 = "]) diff --git a/lldb/test/API/commands/expression/pr35310/TestExprsBug35310.py b/lldb/test/API/commands/expression/pr35310/TestExprsBug35310.py index 2bf1b866c22f7..76a7ada8eb8aa 100644 --- a/lldb/test/API/commands/expression/pr35310/TestExprsBug35310.py +++ b/lldb/test/API/commands/expression/pr35310/TestExprsBug35310.py @@ -4,7 +4,7 @@ from lldbsuite.test import lldbutil -@skipIfWasm # no expression evaluation +@requireNotWasm # no expression evaluation class ExprBug35310(TestBase): def setUp(self): # Call super's setUp(). diff --git a/lldb/test/API/commands/expression/radar_9531204/TestPrintfAfterUp.py b/lldb/test/API/commands/expres... [truncated] `````````` </details> https://github.com/llvm/llvm-project/pull/213465 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
