llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Nerixyz (Nerixyz) <details> <summary>Changes</summary> Found when looking through the generated Python file. `sig` doesn't exist in that context, it should be `idx`. --- Full diff: https://github.com/llvm/llvm-project/pull/213527.diff 2 Files Affected: - (modified) lldb/bindings/interface/SBUnixSignalsExtensions.i (+1-1) - (modified) lldb/test/API/python_api/signals/TestSignalsAPI.py (+6) ``````````diff diff --git a/lldb/bindings/interface/SBUnixSignalsExtensions.i b/lldb/bindings/interface/SBUnixSignalsExtensions.i index 31c7351f1b5dc..ee6ce43e5075e 100644 --- a/lldb/bindings/interface/SBUnixSignalsExtensions.i +++ b/lldb/bindings/interface/SBUnixSignalsExtensions.i @@ -11,7 +11,7 @@ def get_unix_signals_list(self): signals = [] for idx in range(0, self.GetNumSignals()): - signals.append(self.GetSignalAtIndex(sig)) + signals.append(self.GetSignalAtIndex(idx)) return signals threads = property(get_unix_signals_list, None, doc='''A read only property that returns a list() of valid signal numbers for this platform.''') diff --git a/lldb/test/API/python_api/signals/TestSignalsAPI.py b/lldb/test/API/python_api/signals/TestSignalsAPI.py index 4b6c7e4214455..f4c967e4b5692 100644 --- a/lldb/test/API/python_api/signals/TestSignalsAPI.py +++ b/lldb/test/API/python_api/signals/TestSignalsAPI.py @@ -50,3 +50,9 @@ def test_ignore_signal(self): self.assertEqual( process.GetExitStatus(), 0, "The process should have returned 0" ) + + self.assertIn( + sigint, + unix_signals.get_unix_signals_list(), + "SIGINT should be in the list of supported signals", + ) `````````` </details> https://github.com/llvm/llvm-project/pull/213527 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
