llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) <details> <summary>Changes</summary> create_debug_adapter passes the commands that carry the configuration the test suite was invoked with, and a test that builds a DebugAdapterServer itself got none of them, so that session ran unconfigured. It matters wherever the suite configures the debugger through settings, such as pointing a platform at the runtime it launches. --- Full diff: https://github.com/llvm/llvm-project/pull/213553.diff 1 Files Affected: - (modified) lldb/test/API/tools/lldb-dap/server/TestDAP_server.py (+3-1) ``````````diff diff --git a/lldb/test/API/tools/lldb-dap/server/TestDAP_server.py b/lldb/test/API/tools/lldb-dap/server/TestDAP_server.py index 1cbda50e07dd5..1debd6c3d07f8 100644 --- a/lldb/test/API/tools/lldb-dap/server/TestDAP_server.py +++ b/lldb/test/API/tools/lldb-dap/server/TestDAP_server.py @@ -44,7 +44,9 @@ def run_debug_session( self, connection: str, name: str, *, sleep_seconds_in_middle: float = 0 ): self.dap_server = dap_server.DebugAdapterServer( - connection=connection, spawn_helper=self.spawnSubprocess + connection=connection, + init_commands=self.setUpCommands(), + spawn_helper=self.spawnSubprocess, ) program = self.getBuildArtifact("a.out") source = "main.c" `````````` </details> https://github.com/llvm/llvm-project/pull/213553 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
