DavidSpickett wrote: > We only want check if it contains the arm prefix.
Because `armv8l` and `arm64` have the same prefix, does that mean we're missing coverage by only checking that it's contained? I think probably not because the conversions you implemented didn't include any Arm architecture names, right? And if we confuse 32-bit Arm with 64-bit Arm a buildbot will fail anyway, we don't need this test to catch that. I think this test's main concern is the riscv and x86 names gdb-sever produces. https://github.com/llvm/llvm-project/pull/214771 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
