DavidSpickett wrote:

> Some code formatting issues are left.

Fixed.

> There still might be cache collisions, since xml id is feature local, but it 
> can be a follow up

Yes that's true.

> should we cache by RegisterType object identity/UID, not XML ID alone?

I think this is the way to go for now. Especially given that we don't need the 
string type names for anything yet. Going to try it out now.

https://github.com/llvm/llvm-project/pull/213897
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to