jimingham wrote: Thanks for doing this. The code looks right.
Historical comments like the first one here are appropriate in a commit message, since they are documenting the transition point from wrong to right, but not in the code. They end up just being confusing because the wrong code is no longer in evidence. The right way to defend the correct behavior is to assert it in tests - as you have done, or say explicitly what the correct behavior is. No need to mention the previous wrong behavior. There are cases - when the wrong behavior was close enough to the right behavior that it was tricky to choose between them. But in this case we were just violating our own contract and didn't have tests to defend it. So if you can tighten up the comment, then this is good to go. https://github.com/llvm/llvm-project/pull/215521 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
