DavidSpickett wrote: > the two issues I found here are:
Agree with all those. Let's delay this change until we are able to write tests that would catch those things. > lmk if you have time to fix this PR, otherwise I will create the PR with ur > current changes + fix. I don't have the time please go ahead. Though I think we need to be able to test what you suggest, the XML parsing must be fixed first. Unless you're going to test the type builder itself which is also but until now I've done it via. an API test that starts from XML. If you're going to handle multiple targets, I think it will have to be an API test. https://github.com/llvm/llvm-project/pull/215578 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
