llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Raphael Isemann (Teemperor) <details> <summary>Changes</summary> The guard used `_cplusplus` instead of `__cplusplus`. Since `_cplusplus` is never defined it expanded to 0, so `0 < 201402L` was always true and the header unconditionally redefined LLDB_DEPRECATED and LLDB_DEPRECATED_FIXME to nothing. The result was that every deprecation marker in the SB API was always empty. This bug existed since the introduction of the LLDB_DEPRECATED macro in 2279f77d2855d9caa0ece466462d34bcfdf4fb3d . --- Full diff: https://github.com/llvm/llvm-project/pull/215818.diff 1 Files Affected: - (modified) lldb/include/lldb/API/SBDefines.h (+1-1) ``````````diff diff --git a/lldb/include/lldb/API/SBDefines.h b/lldb/include/lldb/API/SBDefines.h index 7ec8e56067aa6..ed7f34d924c45 100644 --- a/lldb/include/lldb/API/SBDefines.h +++ b/lldb/include/lldb/API/SBDefines.h @@ -32,7 +32,7 @@ // Don't add the deprecated attribute when generating the bindings or when // building for anything older than C++14 which is the first version that // supports the attribute. -#if defined(SWIG) || _cplusplus < 201402L +#if defined(SWIG) || __cplusplus < 201402L #undef LLDB_DEPRECATED #undef LLDB_DEPRECATED_FIXME #define LLDB_DEPRECATED(MSG) `````````` </details> https://github.com/llvm/llvm-project/pull/215818 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
