llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Raphael Isemann (Teemperor) <details> <summary>Changes</summary> Every other SB class in the API declares `explicit operator bool()`. SBFile was the only one with an implicit conversion, which in general is not something we want. --- Full diff: https://github.com/llvm/llvm-project/pull/215819.diff 1 Files Affected: - (modified) lldb/include/lldb/API/SBFile.h (+1-1) ``````````diff diff --git a/lldb/include/lldb/API/SBFile.h b/lldb/include/lldb/API/SBFile.h index 8cf4fe1b405fa..c73a134e34d22 100644 --- a/lldb/include/lldb/API/SBFile.h +++ b/lldb/include/lldb/API/SBFile.h @@ -43,7 +43,7 @@ class LLDB_API SBFile { bool IsValid() const; SBError Close(); - operator bool() const; + explicit operator bool() const; #ifndef SWIG bool operator!() const; #endif `````````` </details> https://github.com/llvm/llvm-project/pull/215819 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
