bulbazord wrote:

> I think having the ReExportInfo contain a `ConstString funcname; ConstString 
> dir; ConstString file` where dir+file are populated lazily as the re-export 
> symbol is dereferenced, would be a reasonable approach. By default nothing 
> gets added to the const string pool unless the symbol is explored. I'd say 
> `std::string` but that would also be much too large, especially for the most 
> common case where the target library name hasn't been requested.

Seems alright to me. We could also explore shrinking the size of FileSpec a 
bit, but you may dynamically pay the cost if the size of the stored dir/file 
would be too small.

As I continue removing ConstString in a few places, I will keep in mind the 
Symbol sizing constraints.

https://github.com/llvm/llvm-project/pull/213356
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to