Author: amccarth Date: Thu Sep 7 11:29:48 2017 New Revision: 312735 URL: http://llvm.org/viewvc/llvm-project?rev=312735&view=rev Log: Fix for bug 34510 - Minidump target does not resolve new symbols correctly
Even though the content of the minidump does not change in a debugging session, frames can't be indiscriminately be cached since modules and symbols can be explicitly added after the minidump is loaded. The fix is simple, just let the base Thread::ClearStackFrames() do its job. submitted by amccarth on behalf of lemo Bug: https://bugs.llvm.org/show_bug.cgi?id=34510 Differential Revision: https://reviews.llvm.org/D37527 Modified: lldb/trunk/source/Plugins/Process/minidump/ThreadMinidump.cpp lldb/trunk/source/Plugins/Process/minidump/ThreadMinidump.h Modified: lldb/trunk/source/Plugins/Process/minidump/ThreadMinidump.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/minidump/ThreadMinidump.cpp?rev=312735&r1=312734&r2=312735&view=diff ============================================================================== --- lldb/trunk/source/Plugins/Process/minidump/ThreadMinidump.cpp (original) +++ lldb/trunk/source/Plugins/Process/minidump/ThreadMinidump.cpp Thu Sep 7 11:29:48 2017 @@ -43,8 +43,6 @@ ThreadMinidump::~ThreadMinidump() {} void ThreadMinidump::RefreshStateAfterStop() {} -void ThreadMinidump::ClearStackFrames() {} - RegisterContextSP ThreadMinidump::GetRegisterContext() { if (!m_reg_context_sp) { m_reg_context_sp = CreateRegisterContextForFrame(nullptr); Modified: lldb/trunk/source/Plugins/Process/minidump/ThreadMinidump.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/minidump/ThreadMinidump.h?rev=312735&r1=312734&r2=312735&view=diff ============================================================================== --- lldb/trunk/source/Plugins/Process/minidump/ThreadMinidump.h (original) +++ lldb/trunk/source/Plugins/Process/minidump/ThreadMinidump.h Thu Sep 7 11:29:48 2017 @@ -37,8 +37,6 @@ public: lldb::RegisterContextSP CreateRegisterContextForFrame(StackFrame *frame) override; - void ClearStackFrames() override; - protected: lldb::RegisterContextSP m_thread_reg_ctx_sp; llvm::ArrayRef<uint8_t> m_gpregset_data; _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits