llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Augusto Noronha (augusto2112) <details> <summary>Changes</summary> Arm64eTestBase.build() only overrode TRIPLE, but ARCH_CFLAGS is a Make command-line variable set separately by the test harness to a non-arm64e flag. A plain in-Makefile assignment can't override a command-line variable, so the compiler silently fell back to the host's default (non-arm64e) triple and __ptrauth attributes failed to compile. Now overrides ARCH_CFLAGS too. --- Full diff: https://github.com/llvm/llvm-project/pull/216397.diff 1 Files Affected: - (modified) lldb/packages/Python/lldbsuite/test/lldbarm64e.py (+3-1) ``````````diff diff --git a/lldb/packages/Python/lldbsuite/test/lldbarm64e.py b/lldb/packages/Python/lldbsuite/test/lldbarm64e.py index a16ea85f8bfcd..f6c8f5b962670 100644 --- a/lldb/packages/Python/lldbsuite/test/lldbarm64e.py +++ b/lldb/packages/Python/lldbsuite/test/lldbarm64e.py @@ -6,6 +6,8 @@ @skipUnlessArm64eSupported class Arm64eTestBase(TestBase): def build(self): + triple = configuration.triple.replace("arm64-", "arm64e-") super().build( - dictionary={"TRIPLE": configuration.triple.replace("arm64-", "arm64e-")} + dictionary={"TRIPLE": triple, "ARCH_CFLAGS": "-target " + triple} ) + `````````` </details> https://github.com/llvm/llvm-project/pull/216397 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
