================
@@ -82,6 +82,12 @@ class MemoryCache {
// returns a pointer into that entry's data at the correct offset. Returns
// nullptr on a miss. Caller must hold m_mutex.
const uint8_t *FindL1CacheEntry(lldb::addr_t addr, size_t len) const;
+
+ // If the entire range [addr, addr+len) is covered by a single cache line
+ // that is already in L2, returns a pointer into that line's data at the
+ // correct offset. Never reads from the inferior; returns nullptr on a miss.
----------------
felipepiovezan wrote:
> Never reads from the inferior;
It's probably fine to leave this as is for now, but I wanted to note that we
only need to say this because there is a circular dependency between the memory
cache and process. If the memory cache never had access to a process, then this
would be true by definition.
In a follow up PR, I'll try breaking this dependency.
https://github.com/llvm/llvm-project/pull/216318
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
