[Lldb-commits] [lldb] [lldb] Scope XML register type IDs to features (PR #216384)

[David Spickett via lldb-commits]

================
@@ -5295,25 +5308,29 @@ void ParseFlags(
 bool ParseRegisters(
     XMLNode feature_node, GdbServerTargetInfo &target_info,
     std::vector<DynamicRegisterInfo::Register> &registers,
-    llvm::StringMap<std::unique_ptr<RegisterTypeFlags>> &registers_flags_types,
-    llvm::StringMap<std::unique_ptr<RegisterTypeEnum>> &registers_enum_types) {
+    std::vector<std::unique_ptr<RegisterType>> &owned_register_types) {
   if (!feature_node)
     return false;
 
   Log *log(GetLog(GDBRLog::Process));
+  RegisterTypeMap register_types;
----------------
DavidSpickett wrote:

I suggest calling this `feature_register_types`.

https://github.com/llvm/llvm-project/pull/216384
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits