https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/216723
In a87b27fd5161ec43527fc3356852046a321ea82c, the opposite skip was put in. It should skip if hardware breakpoints are *not* supported. Also that commit added a stray "skip". I have removed that and fixed the incorrect variable name. >From 0555c05a246308c8dcc9c323117f8210ca9ce07c Mon Sep 17 00:00:00 2001 From: David Spickett <[email protected]> Date: Mon, 17 Aug 2026 12:52:28 +0000 Subject: [PATCH 1/2] [lldb][test] Fix skips in TestWriteMemoryWithHWBreakpoint.py In a87b27fd5161ec43527fc3356852046a321ea82c, the opposite skip was put in. It should skip if hardware breakpoints are *not* supported. Also that commit added a stray "skip", remove this. --- .../TestWriteMemoryWithHWBreakpoint.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py b/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py index c82ae24a6d9ab..0fd006d67b53e 100644 --- a/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py +++ b/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py @@ -13,8 +13,7 @@ class WriteMemoryWithHWBreakpoint(HardwareBreakpointTestBase): - @skipTestIfFn(HardwareBreakpointTestBase.supports_hw_breakpoints) - @skip + @skipTestIfFn(HardwareBreakpointTestBase.hw_breakpoints_unsupported) def test_copy_memory_with_hw_break(self): self.build() exe = self.getBuildArtifact("a.out") >From 625e27f261e2e17c0094613672a220cf2d60f5d7 Mon Sep 17 00:00:00 2001 From: David Spickett <[email protected]> Date: Mon, 17 Aug 2026 12:56:36 +0000 Subject: [PATCH 2/2] fix py3 problem --- .../TestWriteMemoryWithHWBreakpoint.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py b/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py index 0fd006d67b53e..c7c4c09454ef0 100644 --- a/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py +++ b/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py @@ -45,4 +45,4 @@ def test_copy_memory_with_hw_break(self): error = lldb.SBError() result = process.WriteMemory(address, data, error) - self.assertTrue(error.Success() and result == len(bytes)) + self.assertTrue(error.Success() and result == len(data)) _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
