jimingham wrote:

> @clayborg @jimingham, added a new commit that changes the `--force` flag and 
> adds a new flag that replaces the old `force` flag.
> 
> ```
> target modules replace [--old-path <path>] [--allow-uuid-mismatch] [--force] 
> <path>
> ```
> 
> Now unless its a placeholder, you always will use `force`, if you want to 
> replace a module and UUID doesn't match we pass `--allow-uuid-mismatch` or 
> `m`.

I haven't looked at the implementation in detail yet.  Under what circumstances 
would you want to use --force and --allow--uuid--mismatch.  Those still don't 
seem safe to me.  In any case, there should be more explanation of the trouble 
you might get into - stranded symbols or accidentally finding the module by 
UUID if another target is holding onto the original module.  There should also 
be some testing of the case where you can't discard the original Module because 
another target is holding onto a reference to it.

https://github.com/llvm/llvm-project/pull/214576
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to