robk-dev wrote: > LGTM. > > The updated comment and commit messages are great! However, when we do merge > PRs here with "squash and merge" (which is the only option) the updated > commit message from the commit itself won't get picked up, but the PR > description is used as template (but whoever presses the button has the > opportunity to reword it). So as you have meaningfully improved the commit > message, I'd suggest you to update the PR description as well, so that > whoever merges it won't have to keep track of copying in the updated message.
Thanks for the suggestion. The old comment was slightly misleading rather than just terse. It claimed the functions don't exist under MinGW, when in fact it was what you and @Nerixyz worked out: in a release build they're no-op macros, so nothing goes wrong, and it only breaks in a debug build. I checked mingw-w64's `crtdbg.h` to be sure of the mechanism — it's a clean `#ifndef _DEBUG` split: ```c #ifndef _DEBUG #define _CrtSetReportMode(t,f) ((int)0) #define _CrtSetReportFile(t,f) ((_HFILE)0) #else /* _DEBUG */ _CRTIMP int __cdecl _CrtSetReportMode(int _ReportType, int _ReportMode); _CRTIMP _HFILE __cdecl _CrtSetReportFile(int _ReportType, _HFILE _ReportFile); #endif /* _DEBUG */ ``` So under `_DEBUG` it compiles fine and fails at *link*, because the release CRT MinGW links doesn't export those symbols. That also explains why mingw-w64-lldb and llvm-mingw never hit it - they're release builds. I've reworded the description and commit message similarly to the comment. https://github.com/llvm/llvm-project/pull/216710 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
