robk-dev wrote:

> > I have not included a regression test...Happy to add either if you have a 
> > preference
> 
> Yea a test would be great

Added a test: 
`lldb/test/Shell/SymbolFile/DWARF/clang-ast-from-dwarf-objc-interface-msvc.m`. 
It compiles a two-level Objective-C interface hierarchy for 
`x86_64-pc-windows-msvc`, links it with `lld-link -debug:dwarf`, and dumps the 
AST LLDB builds from that DWARF with `lldb-test symbols -dump-clang-ast`. I 
checked both directions: with the fix reverted it segfaults in 
`CXXRecordDecl::calculateInheritanceModel()`, and with it the AST comes out 
intact.

It links a real image rather than running on the `.obj` because `lldb-test` 
reports "Module has no symbol vendor" for a bare COFF object file; hence, the 
`REQUIRES: lld`. Happy to make it a `YAMLModuleTester` unit test instead if 
you'd prefer, though that harness is ELF-only today and the bug needs a 
Microsoft C++ ABI triple, so it would mean teaching it COFF first.

https://github.com/llvm/llvm-project/pull/216711
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to