https://github.com/jimingham approved this pull request.
I'm not sure about the name. This name is declarative. What we know is that Commands MIGHT be run directly by the user, but for instance a Frame Provider can't. So maybe CanRunOnUsersBehalf would better express what you know about the Interface type. Or maybe UserCanRunDirectly? In the fullness of time, we'll set and retrieve policy information about how these Interfaces should behave from the currently executing context. For instance, if you are running a policy that says you don't have to check the API lock, and you call HandleCommand, the command you invoke will inherit its "do I need to take the lock" from that environment, so this is just describing the possible, not current, behavior. LGTM except the choice of name. https://github.com/llvm/llvm-project/pull/208242 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
