satyajanga wrote: > Aren't the two changes cancelling each other out? The change to > `SymbolFileDWARF` makes the line table conditional on the debug info (which > matches your first claim) but the only way to outrank SymbolFileSymtab is if > you return only `LineTables`. > > It looks like the fix you want it to check `CompileUnits`. LineTables only > shouldn't win without a CompileUnit to attach it to. > SymbolFilePDB::CalculateAbilities returns exactly LineTables when the Symbols > table is empty and LineNumbers is not, and with this change it now outranks > SymbolFileSymtab. I think that if you require CompileUnits alongside > LineTables in the predicate, you fix PDB too and you can drop the > SymbolFileDWARF change.
Great point. thanks instead of changing the all plugins I changed the ranking logic to consider that. https://github.com/llvm/llvm-project/pull/218030 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
