================
@@ -75,17 +75,26 @@ const char *SBEnvironment::GetValueAtIndex(size_t index) {
bool SBEnvironment::Set(const char *name, const char *value, bool overwrite) {
LLDB_INSTRUMENT_VA(this, name, value, overwrite);
+ llvm::StringRef name_ref{name};
+ if (name_ref.trim().empty())
+ return false;
+
+ llvm::StringRef value_ref{value};
if (overwrite) {
- m_opaque_up->insert_or_assign(name, std::string(value));
+ m_opaque_up->insert_or_assign(name_ref, value_ref.str());
return true;
}
- return m_opaque_up->try_emplace(name, std::string(value)).second;
+ return m_opaque_up->try_emplace(name_ref, value_ref.str()).second;
}
bool SBEnvironment::Unset(const char *name) {
LLDB_INSTRUMENT_VA(this, name);
- return m_opaque_up->erase(name);
+ llvm::StringRef name_ref{name};
+ if (name_ref.trim().empty())
+ return false;
+
+ return m_opaque_up->erase(llvm::StringRef(name));
----------------
bulbazord wrote:
```suggestion
return m_opaque_up->erase(llvm::StringRef(name_ref));
```
https://github.com/llvm/llvm-project/pull/218906
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
