qiyao wrote: > This looks good to me. I might have treated a cache line size of 0 as meaning > "disable the memory read cache", duplicating the behavior of > `target.process.disable-memory-cache`. But this is probably a better approach.
My impression was similar, set cache line size of 0 means "disable the L2 cache". However, `Process::ReadCStringFromMemory` already assumes cache line size can't be zero. https://github.com/llvm/llvm-project/blob/0ab4db419396839196100494fcce9437403ee7cc/lldb/source/Target/Process.cpp#L2379-L2380 https://github.com/llvm/llvm-project/pull/219217 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
