MrEven132 wrote: @JDevlieghere Thanks for the review. I've updated the patch to address the feedback.
`DWARFExpression::Stack` now owns a single vector of entries, with each entry storing both its `Value` and `LocationDescriptionKind`. The stack class has also been moved to `DWARFExpression.h`, and direct unit tests have been added to `DWARFExpressionTest.cpp`. `PushCopy`, `SwapTopTwo`, and `RotateTopThree` now return `false` for invalid indices or insufficient stack depth, and the evaluator checks those results. The tests cover push/pop, location-kind updates, copying, swapping, rotation, and empty or undersized stacks. The focused regression and stack tests pass (5/5), as does the full `ExpressionTests` suite (166/166). https://github.com/llvm/llvm-project/pull/219372 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
