DavidSpickett wrote: It's quite difficult to understand what is what in this PR due to the "stacking". It's not bad that you did it that way in general, it can work, but I'm looking at the commit list and can't figure out what I'm looking at.
For true stacked PRs you need to use user branches on llvm/llvm-project, which probably needs commit access. These being your first PRs I think, that might be a circular dependency. Considering that no review has happened yet, you could squash all the parts of the earlier PRs into one commit, then optionally squash all the commits that are for this PR into one, and force push the result. Then you can say "the first commit is earlier PRs required for this to build properly, please review the further commits". Another more extreme way, as long as the files between PRs don't overlap, is to just present them separately with the caveat that the later ones won't build correctly yet. Depends what we're reviewing whether that makes sense to do. I have ideas of people to review this but I would like it to be clear to them at first glance exactly what to review. https://github.com/llvm/llvm-project/pull/218014 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
