llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) <details> <summary>Changes</summary> sanitized bots don't use the just-built debugserver, so any tests exercising new debugserver features won't work on them. --- Full diff: https://github.com/llvm/llvm-project/pull/220919.diff 2 Files Affected: - (modified) lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py (+1-2) - (modified) lldb/test/API/functionalities/breakpoint/write_over_software_breakpoint/TestWriteOverSoftwareBreakpoint.py (+1-2) ``````````diff diff --git a/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py b/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py index de90f8f65e218..402c152c05224 100644 --- a/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py +++ b/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py @@ -14,8 +14,7 @@ class WriteMemoryWithHWBreakpoint(HardwareBreakpointTestBase): @skipTestIfFn(HardwareBreakpointTestBase.hw_breakpoints_unsupported) - # Fails with a sanitized build of debugserver. https://github.com/llvm/llvm-project/issues/220844 - @llgs_test + @skipIfOutOfTreeDebugserver def test_write_memory_with_hw_break(self): self.build() exe = self.getBuildArtifact("a.out") diff --git a/lldb/test/API/functionalities/breakpoint/write_over_software_breakpoint/TestWriteOverSoftwareBreakpoint.py b/lldb/test/API/functionalities/breakpoint/write_over_software_breakpoint/TestWriteOverSoftwareBreakpoint.py index d023624454443..1821e0fbfe7f3 100644 --- a/lldb/test/API/functionalities/breakpoint/write_over_software_breakpoint/TestWriteOverSoftwareBreakpoint.py +++ b/lldb/test/API/functionalities/breakpoint/write_over_software_breakpoint/TestWriteOverSoftwareBreakpoint.py @@ -15,8 +15,7 @@ class WriteOverSoftwareBreakpoint(TestBase): # Could not find a way to make place_break_here visible to lldb on Windows. @skipIfWindows - # Fails with a sanitized build of debugserver. https://github.com/llvm/llvm-project/issues/220844 - @llgs_test + @skipIfOutOfTreeDebugserver def test_write_over_breakpoint(self): TestBase.setUp(self) self.line = line_number("main.c", "// break here") `````````` </details> https://github.com/llvm/llvm-project/pull/220919 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
