llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lldb
Author: Charles Zablit (charles-zablit)
<details>
<summary>Changes</summary>
- Add requireClang, marking Clang-only tests as UNSUPPORTED elsewhere instead
of SKIPPED, following the existing require* convention.
- Replace the ~30 standalone @<!-- -->skipIf(compiler=no_match("clang")) uses
with @<!-- -->requireClang; leave the cases paired with a compiler_version
check as-is, since those are more complex than a simple compiler check.
- Remove the now-unused skipUnlessCompilerIsClang in favor of requireClang.
- Update the testing docs to mention requireClang.
Follow-up to #<!-- -->214197, as discussed with @<!-- -->DavidSpickett.
---
Patch is 23.51 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/222007.diff
29 Files Affected:
- (modified) lldb/docs/resources/test.md (+6-3)
- (modified) lldb/packages/Python/lldbsuite/test/decorators.py (+9-13)
- (modified)
lldb/test/API/commands/expression/import-std-module/array/TestArrayFromStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/basic/TestImportStdModule.py
(+2-2)
- (modified)
lldb/test/API/commands/expression/import-std-module/conflicts/TestStdModuleWithConflicts.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/empty-module/TestEmptyStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/forward_decl_from_module/TestForwardDeclFromStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/forward_list-dbg-info-content/TestDbgInfoContentForwardListFromStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/forward_list/TestForwardListFromStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/iterator/TestIteratorFromStdModule.py
(+2-2)
- (modified)
lldb/test/API/commands/expression/import-std-module/list/TestListFromStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/missing-module-sources/TestStdModuleSourcesMissing.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/module-build-errors/TestStdModuleBuildErrors.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/no-std-module/TestMissingStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/non-module-type-separation/TestNonModuleTypeSeparation.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/pair/TestPairFromStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/queue/TestQueueFromStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/retry-with-std-module/TestRetryWithStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/shared_ptr-dbg-info-content/TestSharedPtrDbgInfoContentFromStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/stack/TestStackFromStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/sysroot/TestStdModuleSysroot.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/vector-bool/TestVectorBoolFromStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/vector-of-vectors/TestVectorOfVectorsFromStdModule.py
(+1-1)
- (modified)
lldb/test/API/commands/expression/import-std-module/vector/TestVectorFromStdModule.py
(+1-1)
- (modified) lldb/test/API/commands/frame/var/TestFrameVar.py (+1-1)
- (modified)
lldb/test/API/functionalities/breakpoint/jit_loader_rtdyld_elf/TestJitBreakPoint.py
(+1-1)
- (modified) lldb/test/API/lang/cpp/abi_tag_structors/TestAbiTagStructors.py
(+3-3)
- (modified) lldb/test/API/lang/cpp/forward/TestCPPForwardDeclaration.py (+1-1)
``````````diff
diff --git a/lldb/docs/resources/test.md b/lldb/docs/resources/test.md
index 711625133c4b1..5aaefc077e7d1 100644
--- a/lldb/docs/resources/test.md
+++ b/lldb/docs/resources/test.md
@@ -159,12 +159,15 @@ decorator you pick says which:
The `require*` decorators mirror the `skip*` ones one-for-one:
`requireDarwin` / `requireNotDarwin`, `requireLinux` / `requireNotLinux`,
`requireWindows` / `requireNotWindows`, plus `requirePOSIX`, `requireSignals`,
-`requireNotWasm`, `requireDarwinHost`, and the general
+`requireNotWasm`, `requireDarwinHost`, `requireClang`, and the general
`requirePlatform(oslist)` / `requireNotPlatform(oslist)`.
Reach for `require*` when the test is tied to a platform-specific file format,
-API, or OS feature. If the test is merely untested or broken somewhere, keep
-`skipIf*` so nobody mistakes a bug for a design decision.
+API, or OS feature, or to a specific compiler. If the test is merely untested
+or broken somewhere, keep `skipIf*` so nobody mistakes a bug for a design
+decision. For example, a test that only uses Clang-specific debug info
+options belongs behind `@requireClang` rather than
+`@skipIf(compiler=no_match("clang"))`.
In addition to providing a lot more flexibility when it comes to writing the
test, the API test also allow for much more complex scenarios when it comes to
diff --git a/lldb/packages/Python/lldbsuite/test/decorators.py
b/lldb/packages/Python/lldbsuite/test/decorators.py
index 70f7122c53c16..4cad3500b7d83 100644
--- a/lldb/packages/Python/lldbsuite/test/decorators.py
+++ b/lldb/packages/Python/lldbsuite/test/decorators.py
@@ -1313,6 +1313,15 @@ def requireSocketPermission(func):
return unittest.skipIf(error is not None, UnsupportedReason(error or
""))(func)
+def requireClang(func):
+ """Mark the item as inherently Clang-only (Clang-specific debug info,
+ diagnostics, or command-line flags)."""
+ compiler = os.path.basename(lldbplatformutil.getCompiler())
+ return unittest.skipUnless(
+ compiler.startswith("clang"), UnsupportedReason("requires clang")
+ )(func)
+
+
def skipIfTargetDoesNotSupportSharedLibraries():
"""Skip tests that require shared library (dylib/so) support."""
platform = lldbplatformutil.getPlatform()
@@ -1412,19 +1421,6 @@ def is_compiler_clang_with_call_site_info():
return skipTestIfFn(is_compiler_clang_with_call_site_info)(func)
-def skipUnlessCompilerIsClang(func):
- """Decorate the item to skip test unless the compiler is clang."""
-
- def is_compiler_clang():
- compiler_path = lldbplatformutil.getCompiler()
- compiler = os.path.basename(compiler_path)
- if not compiler.startswith("clang"):
- return "Test requires clang as compiler"
- return None
-
- return skipTestIfFn(is_compiler_clang)(func)
-
-
def skipUnlessMSVC(func):
"""Decorate the item to skip test unless msvc is available."""
diff --git
a/lldb/test/API/commands/expression/import-std-module/array/TestArrayFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/array/TestArrayFromStdModule.py
index 9fa1bd048252b..edf204a80d48d 100644
---
a/lldb/test/API/commands/expression/import-std-module/array/TestArrayFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/array/TestArrayFromStdModule.py
@@ -9,7 +9,7 @@
class TestCase(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_version=["<", "15.0"])
@skipIf(
bugnumber="ASTImport of lambdas not supported:
https://github.com/llvm/llvm-project/issues/149477";
diff --git
a/lldb/test/API/commands/expression/import-std-module/basic/TestImportStdModule.py
b/lldb/test/API/commands/expression/import-std-module/basic/TestImportStdModule.py
index a99ea10ae9330..d385707869505 100644
---
a/lldb/test/API/commands/expression/import-std-module/basic/TestImportStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/basic/TestImportStdModule.py
@@ -9,7 +9,7 @@
class ImportStdModule(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_version=["<", "15.0"])
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
@@ -39,7 +39,7 @@ def test(self):
)
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_version=["<", "15.0"])
@skipIf(macos_sdk_version=["<", "16.0"])
def test_non_cpp_language(self):
diff --git
a/lldb/test/API/commands/expression/import-std-module/conflicts/TestStdModuleWithConflicts.py
b/lldb/test/API/commands/expression/import-std-module/conflicts/TestStdModuleWithConflicts.py
index 5bd319e94be6d..00bd376b0ee28 100644
---
a/lldb/test/API/commands/expression/import-std-module/conflicts/TestStdModuleWithConflicts.py
+++
b/lldb/test/API/commands/expression/import-std-module/conflicts/TestStdModuleWithConflicts.py
@@ -14,7 +14,7 @@
class TestImportStdModuleConflicts(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_version=["<", "15.0"])
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
diff --git
a/lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py
index ee4db68059c66..14231d4003b0e 100644
---
a/lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py
@@ -9,7 +9,7 @@
class TestBasicDeque(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_version=["<", "15.0"])
@skipIf(
bugnumber="ASTImport of lambdas not supported:
https://github.com/llvm/llvm-project/issues/149477";
diff --git
a/lldb/test/API/commands/expression/import-std-module/empty-module/TestEmptyStdModule.py
b/lldb/test/API/commands/expression/import-std-module/empty-module/TestEmptyStdModule.py
index 4273d80d96640..3eed88213829e 100644
---
a/lldb/test/API/commands/expression/import-std-module/empty-module/TestEmptyStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/empty-module/TestEmptyStdModule.py
@@ -14,7 +14,7 @@ class ImportStdModule(TestBase):
# test configurations where libc++ is actually supposed to be tested.
@add_test_categories(["libc++"])
@skipIfRemote
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
self.build()
diff --git
a/lldb/test/API/commands/expression/import-std-module/forward_decl_from_module/TestForwardDeclFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/forward_decl_from_module/TestForwardDeclFromStdModule.py
index 465e62eac3527..a80e8fdde7038 100644
---
a/lldb/test/API/commands/expression/import-std-module/forward_decl_from_module/TestForwardDeclFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/forward_decl_from_module/TestForwardDeclFromStdModule.py
@@ -14,7 +14,7 @@ class TestCase(TestBase):
# test configurations where libc++ is actually supposed to be tested.
@add_test_categories(["libc++"])
@skipIfRemote
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
self.build()
diff --git
a/lldb/test/API/commands/expression/import-std-module/forward_list-dbg-info-content/TestDbgInfoContentForwardListFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/forward_list-dbg-info-content/TestDbgInfoContentForwardListFromStdModule.py
index da094d5d828d4..cdf8953aa1bbc 100644
---
a/lldb/test/API/commands/expression/import-std-module/forward_list-dbg-info-content/TestDbgInfoContentForwardListFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/forward_list-dbg-info-content/TestDbgInfoContentForwardListFromStdModule.py
@@ -9,7 +9,7 @@
class TestDbgInfoContentForwardList(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_version=["<", "15.0"])
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
diff --git
a/lldb/test/API/commands/expression/import-std-module/forward_list/TestForwardListFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/forward_list/TestForwardListFromStdModule.py
index 03cb539cd1f11..5c42d5c9b3cc8 100644
---
a/lldb/test/API/commands/expression/import-std-module/forward_list/TestForwardListFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/forward_list/TestForwardListFromStdModule.py
@@ -9,7 +9,7 @@
class TestBasicForwardList(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_version=["<", "15.0"])
@skipIf(
bugnumber="ASTImport of lambdas not supported:
https://github.com/llvm/llvm-project/issues/149477";
diff --git
a/lldb/test/API/commands/expression/import-std-module/iterator/TestIteratorFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/iterator/TestIteratorFromStdModule.py
index 0502e7b4342c7..9dfc90c99a0e8 100644
---
a/lldb/test/API/commands/expression/import-std-module/iterator/TestIteratorFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/iterator/TestIteratorFromStdModule.py
@@ -9,7 +9,7 @@
class TestCase(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_version=["<", "15.0"])
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
@@ -29,7 +29,7 @@ def test(self):
self.expect_expr("move_begin + 3 == move_end", result_value="true")
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@expectedFailureAll(bugnumber="https://github.com/llvm/llvm-project/issues/149477";)
@skipIf(macos_sdk_version=["<", "16.0"])
def test_xfail(self):
diff --git
a/lldb/test/API/commands/expression/import-std-module/list/TestListFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/list/TestListFromStdModule.py
index 08b68d309a602..14b887c1242b9 100644
---
a/lldb/test/API/commands/expression/import-std-module/list/TestListFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/list/TestListFromStdModule.py
@@ -9,7 +9,7 @@
class TestBasicList(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_version=["<", "15.0"])
@skipIf(
bugnumber="ASTImport of lambdas not supported:
https://github.com/llvm/llvm-project/issues/149477";
diff --git
a/lldb/test/API/commands/expression/import-std-module/missing-module-sources/TestStdModuleSourcesMissing.py
b/lldb/test/API/commands/expression/import-std-module/missing-module-sources/TestStdModuleSourcesMissing.py
index ab0028cc63258..b107ce393d211 100644
---
a/lldb/test/API/commands/expression/import-std-module/missing-module-sources/TestStdModuleSourcesMissing.py
+++
b/lldb/test/API/commands/expression/import-std-module/missing-module-sources/TestStdModuleSourcesMissing.py
@@ -14,7 +14,7 @@ class TestCase(TestBase):
# but we still add the libc++ category so that this test is only run in
# test configurations where libc++ is actually supposed to be tested.
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIfRemote
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
diff --git
a/lldb/test/API/commands/expression/import-std-module/module-build-errors/TestStdModuleBuildErrors.py
b/lldb/test/API/commands/expression/import-std-module/module-build-errors/TestStdModuleBuildErrors.py
index 81f77a175d035..ab56ffed720be 100644
---
a/lldb/test/API/commands/expression/import-std-module/module-build-errors/TestStdModuleBuildErrors.py
+++
b/lldb/test/API/commands/expression/import-std-module/module-build-errors/TestStdModuleBuildErrors.py
@@ -18,7 +18,7 @@ class TestCase(TestBase):
# test configurations where libc++ is actually supposed to be tested.
@add_test_categories(["libc++"])
@skipIfRemote
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
self.build()
diff --git
a/lldb/test/API/commands/expression/import-std-module/no-std-module/TestMissingStdModule.py
b/lldb/test/API/commands/expression/import-std-module/no-std-module/TestMissingStdModule.py
index c400613045923..9e079b48d568f 100644
---
a/lldb/test/API/commands/expression/import-std-module/no-std-module/TestMissingStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/no-std-module/TestMissingStdModule.py
@@ -15,7 +15,7 @@
class STLTestCase(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
self.build()
diff --git
a/lldb/test/API/commands/expression/import-std-module/non-module-type-separation/TestNonModuleTypeSeparation.py
b/lldb/test/API/commands/expression/import-std-module/non-module-type-separation/TestNonModuleTypeSeparation.py
index 358944817cce3..c88eec2c0e554 100644
---
a/lldb/test/API/commands/expression/import-std-module/non-module-type-separation/TestNonModuleTypeSeparation.py
+++
b/lldb/test/API/commands/expression/import-std-module/non-module-type-separation/TestNonModuleTypeSeparation.py
@@ -10,7 +10,7 @@
class TestCase(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_version=["<", "15.0"])
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
diff --git
a/lldb/test/API/commands/expression/import-std-module/pair/TestPairFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/pair/TestPairFromStdModule.py
index a2e7a0aff410c..1a5625d04a003 100644
---
a/lldb/test/API/commands/expression/import-std-module/pair/TestPairFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/pair/TestPairFromStdModule.py
@@ -9,7 +9,7 @@
class TestCase(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
# FIXME: This regressed in 69d5a6662115499198ebfa07a081e98a6ce4b915
# but needs further investigation for what underlying Clang/LLDB bug can't
# handle that code change.
diff --git
a/lldb/test/API/commands/expression/import-std-module/queue/TestQueueFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/queue/TestQueueFromStdModule.py
index c4a08a9325641..c07d67e121535 100644
---
a/lldb/test/API/commands/expression/import-std-module/queue/TestQueueFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/queue/TestQueueFromStdModule.py
@@ -9,7 +9,7 @@
class TestQueue(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(
compiler="clang",
compiler_version=[">", "16.0"],
diff --git
a/lldb/test/API/commands/expression/import-std-module/retry-with-std-module/TestRetryWithStdModule.py
b/lldb/test/API/commands/expression/import-std-module/retry-with-std-module/TestRetryWithStdModule.py
index d15566bf172d9..deeb3bb4a8d27 100644
---
a/lldb/test/API/commands/expression/import-std-module/retry-with-std-module/TestRetryWithStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/retry-with-std-module/TestRetryWithStdModule.py
@@ -5,7 +5,7 @@
class TestCase(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_version=["<", "15.0"])
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
diff --git
a/lldb/test/API/commands/expression/import-std-module/shared_ptr-dbg-info-content/TestSharedPtrDbgInfoContentFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/shared_ptr-dbg-info-content/TestSharedPtrDbgInfoContentFromStdModule.py
index 78922469592f4..3a0b1c74e2d04 100644
---
a/lldb/test/API/commands/expression/import-std-module/shared_ptr-dbg-info-content/TestSharedPtrDbgInfoContentFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/shared_ptr-dbg-info-content/TestSharedPtrDbgInfoContentFromStdModule.py
@@ -9,7 +9,7 @@
class TestSharedPtrDbgInfoContent(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_version=["<", "15.0"])
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
diff --git
a/lldb/test/API/commands/expression/import-std-module/stack/TestStackFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/stack/TestStackFromStdModule.py
index 77420a6022710..2beb1650d5731 100644
---
a/lldb/test/API/commands/expression/import-std-module/stack/TestStackFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/stack/TestStackFromStdModule.py
@@ -9,7 +9,7 @@
class TestStack(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIfLinux # Declaration in some Linux headers causes LLDB to crash.
@skipIf(bugnumber="rdar://97622854")
@skipIf(macos_sdk_version=["<", "16.0"])
diff --git
a/lldb/test/API/commands/expression/import-std-module/sysroot/TestStdModuleSysroot.py
b/lldb/test/API/commands/expression/import-std-module/sysroot/TestStdModuleSysroot.py
index e6147e724f04c..6a17a07d046a1 100644
---
a/lldb/test/API/commands/expression/import-std-module/sysroot/TestStdModuleSysroot.py
+++
b/lldb/test/API/commands/expression/import-std-module/sysroot/TestStdModuleSysroot.py
@@ -13,7 +13,7 @@ class ImportStdModule(TestBase):
# but we still add the libc++ category so that this test is only run in
# test configurations where libc++ is actually supposed to be tested.
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIfRemote # This test messes with the platform, can't be run remotely.
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
diff --git
a/lldb/test/API/commands/expression/import-std-module/vector-bool/TestVectorBoolFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/vector-bool/TestVectorBoolFromStdModule.py
index 146cab764504f..de3b314924291 100644
---
a/lldb/test/API/commands/expression/import-std-module/vector-bool/TestVectorBoolFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/vector-bool/TestVectorBoolFromStdModule.py
@@ -9,7 +9,7 @@
class TestBoolVector(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(bugnumber="rdar://100741983")
@skipIf(macos_sdk_version=["<", "16.0"])
def test(self):
diff --git
a/lldb/test/API/commands/expression/import-std-module/vector-of-vectors/TestVectorOfVectorsFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/vector-of-vectors/TestVectorOfVectorsFromStdModule.py
index aa9b5cb20c87c..e8fc31b85a8b9 100644
---
a/lldb/test/API/commands/expression/import-std-module/vector-of-vectors/TestVectorOfVectorsFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/vector-of-vectors/TestVectorOfVectorsFromStdModule.py
@@ -9,7 +9,7 @@
class TestVectorOfVectors(TestBase):
@add_test_categories(["libc++"])
- @skipIf(compiler=no_match("clang"))
+ @requireClang
@skipIf(macos_version=["<", "15.0"])
@skipIf(
bugnumber="ASTImport of lambdas not supported:
https://github.com/llvm/llvm-project/issues/149477";
diff --git
a/lldb/test/API/commands/expression/import-std-module/vector/TestVectorFromStdModule.py
b/lldb/test/API/commands/expression/import-std-module/vector/TestVectorFromStdModule.py
index 89fbb8404509d..544a0be531f6b 100644
---
a/lldb/test/API/commands/expression/import-std-module/vector/TestVectorFromStdModule.py
+++
b/lldb/test/API/commands/expression/import-std-module/vector/TestVectorFromStd...
[truncated]
``````````
</details>
https://github.com/llvm/llvm-project/pull/222007
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
