jimingham wrote:

The implementation seems fine.  

It's not clear that only SBValue.CreateValueFromExpression "creates values from 
expressions"; after all SBTarget.EvaluateExpression and 
SBFrame.EvaluateExpression also do that job.  I think it's preferable for the 
explicit EvaluateExpression API's to always run the expression parser - so I 
agree with the decision you've made here.  But I think the help string for the 
setting needs to make that clearer.

We should probably also indicate this in the docs for 
SBValue.CreateValueFromExpression, since you probably wouldn't find your way to 
this detail otherwise.

https://github.com/llvm/llvm-project/pull/222192
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to