DavidSpickett wrote: > If you don't like creating new register library, I can just refactor under > Process/Utility. But I think putting them into a separate library prevents > developers from making similar mistakes in future (e.g. mixing register > definitions and platform-specific interface).
It is not clear to me yet what this new library looks like. If it was super clear at first glance then I'd be fine with a new library purely on the principal of better organisation. The less clear the end goal is, the more justification it needs. So if you can show me where you want to end up then I'll probably be fine with it being a library. Doesn't need to be reviewable in that state, just enough so I know that we're not gonna have things like the partial source markers hanging around. https://github.com/llvm/llvm-project/pull/222330 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
