https://github.com/felipepiovezan approved this pull request.
This LGTM modulo the nits. The only high level piece of feedback I have left is that I, personally, would not have tried to handle the cases where address + length overflow, as it makes some parts of the code harder to reason about. This is for two reasons: 1. if this overflows in the LLDB code, it would likely also overflow in the process itself, so realistically this code should never trigger. 2. To provide some safety, I would simply have had an early return at the entry point of the caches: if a addr+length cache request overflows, just don't cache it. https://github.com/llvm/llvm-project/pull/222688 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
