================
@@ -59,12 +59,25 @@ mark_as_advanced(LLDB_LIBXML2_VERSION)
add_optional_dependency(LLDB_ENABLE_SWIG "Enable SWIG to generate LLDB
bindings" SWIG VERSION 4)
add_optional_dependency(LLDB_ENABLE_LIBEDIT "Enable editline support in LLDB"
LibEdit)
add_optional_dependency(LLDB_ENABLE_CURSES "Enable curses support in LLDB"
CursesAndPanel)
-add_optional_dependency(LLDB_ENABLE_LZMA "Enable LZMA compression support in
LLDB" LibLZMA)
add_optional_dependency(LLDB_ENABLE_LUA "Enable Lua scripting support in LLDB"
LuaAndSwig)
add_optional_dependency(LLDB_ENABLE_PYTHON "Enable Python scripting support in
LLDB" PythonAndSwig)
add_optional_dependency(LLDB_ENABLE_LIBXML2 "Enable Libxml 2 support in LLDB"
LibXml2 VERSION ${LLDB_LIBXML2_VERSION})
add_optional_dependency(LLDB_ENABLE_TREESITTER "Enable Tree-sitter syntax
highlighting" TreeSitter)
+# liblzma comes from LLVM, and a standalone build cannot change how LLVM was
+# built, so LLDB_ENABLE_LZMA can only be reported here.
+if(LLDB_BUILT_STANDALONE AND DEFINED LLDB_ENABLE_LZMA)
+ string(TOUPPER "${LLDB_ENABLE_LZMA}" lldb_enable_lzma)
+ if(NOT lldb_enable_lzma STREQUAL "AUTO")
+ message(DEPRECATION
+ "LLDB_ENABLE_LZMA is deprecated and has no effect in a standalone build.
"
----------------
DavidSpickett wrote:
Consider doing two things here:
1. Deprecation warning stating that it basically does nothing now and will be
removed later.
2. Error if the value does not match the LLVM version.
So anyone choosing a specific value that happens to match, they get a notice to
update the option. Anyone not matching, they get a noisy signal that they
aren't going to get what they previously got.
https://github.com/llvm/llvm-project/pull/220092
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
