davide added a comment.

If there are cases where `is_exe` shouldn't be fatal, then we might consider 
splitting the utility into two bits (exists & is_exe).
In my mind, if you're checking whether something is executable you should run 
the check on a valid entity, and it's up to the caller guaranteeing the 
validity (we should, of course, check here).


https://reviews.llvm.org/D39199



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to