Makes sense. I'll update the diff. On Mon, Nov 6, 2017 at 9:28 AM Zachary Turner <ztur...@google.com> wrote:
> This is definitely required, but only on windows. I’d put it behind a > check for Windows, and I’d also add a check to print a warning/error if > (TARGET lld) returns false on windows > On Mon, Nov 6, 2017 at 9:22 AM Davide Italiano via Phabricator < > revi...@reviews.llvm.org> wrote: > >> davide added a subscriber: zturner. >> davide added a comment. >> >> Not sure lld is the default? I think I always build with bfd (or gold). >> I'll check later today when I'm in the office. I'm not against this >> change per se, but adding another dependency seems annoying. cc: @zturner >> >> >> https://reviews.llvm.org/D39689 >> >> >> >> -- -- Stephane Sezer
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
