asmith added inline comments.
================
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:127
+ }
+ lldbassert(m_session_up.get());
+ if (auto enum_tables_up = m_session_up->getEnumTables()) {
----------------
clayborg wrote:
> I am assuming this assert won't fire if we give this an ELF or MachO file or
> any file that doesn't contain PDB info? Every SymbolFile subclass gets to
> calculate its abilities on each file until on of them returns that they can
> handle all abilities, or until all plug-ins have had a chance to answer and
> then the best one is picked. Seems like this shouldn't be here? I can't
> remember what checks get run before SymbolFile::CalculateAbilities() is
> called...
Any ELF or MachO other than PDB or PECOFF will error when calling
loadDataForEXE or loadDataForPDB and return before reaching the assertion.
Repository:
rL LLVM
https://reviews.llvm.org/D41092
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
