zturner added inline comments.
================
Comment at: lit/CMakeLists.txt:10-13
+string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TEST_C_COMPILER
${LLDB_TEST_C_COMPILER})
+string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TEST_CXX_COMPILER
${LLDB_TEST_CXX_COMPILER})
+string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_LIBS_DIR
${LLVM_LIBRARY_OUTPUT_INTDIR})
+string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TOOLS_DIR
${LLVM_RUNTIME_OUTPUT_INTDIR})
----------------
This only works if you're using a just-built clang, which might not be the
case. In fact, it's usually not the case, because it's common to want to run
the test suite against a debug build of lldb but using a release build of clang
(otherwise you'll be there all day waiting for it to finish).
I feel like if the user specifies an absolute path to the test compiler on the
command line, that should be what it uses -- always. If we want to use a just
built toolchain, maybe we need something else, like
`-DLLDB_TEST_BUILT_CLANG=ON`, which would trigger this logic.
As I don't use this configuration though, I'm interested in hearing your
thoughts.
https://reviews.llvm.org/D43096
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
