vsk added inline comments.
================
Comment at: include/lldb/Utility/Log.h:249-254
+ ::lldb_private::Log *log_private = (log);
\
+ if (log_private)
\
+ log_private->FormatError(::std::move(error_private), __FILE__,
\
+ __func__, "{0}");
\
+ else
\
+ ::llvm::consumeError(::std::move(error_private));
\
----------------
labath wrote:
> it looks like this could be just handled by delegating to the LLDB_LOG_ERROR
> macro.
I missed this earlier because I mistakenly named two variables error_private.
At any rate, there's an objection to having a return_if macro so I'm setting it
aside.
https://reviews.llvm.org/D43912
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
