jasonmolenda added a comment.

I think we're being a little hasty here.  Greg's last suggestion is worth 
investigation -- how many tests would actually be run for this new variant?

Greg, maybe you could remove the make clean targets from 
packages/Python/lldbsuite/test/plugins/builder_base.py (I think that'll do it), 
do a testsuite run to create all the test binaries, and then find out how how 
many tests are actually going to be run here?

Pavel is right that the explosion of debug variations will quickly become 
untenable, even with bots, and I'm not sure what a good solution to that is.  
Running the debug information parsers against the wide variety of programs we 
include in the testsuite is a good way to test them.  This is a problem we 
should discuss, but if the practical impact of adding the extra testing for 
.debug_types is that we run 50 tests through an additional variant, I think it 
is premature to draw the line here and say this must be solved now.


https://reviews.llvm.org/D32167



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to