[Lldb-commits] [PATCH] D44157: [elf] Remove one copy of the section merging code

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil accepted this revision.
jankratochvil added a comment.
This revision is now accepted and ready to land.

Yes, it should be the same I think; some notes of mine:

  Module::GetSectionList()->obj_file->CreateSections(*GetUnifiedSectionList());
          Module::GetUnifiedSectionList()->Module::m_sections_ap.get();
  
  ObjectFileELF::CreateSections()->removal
          ObjectFileELF::m_sections_ap.get() ---> Module::m_sections_ap.get();
  
  SymbolVendorELF::CreateInstance()
          ObjectFileSP dsym_objfile_sp->SetType(ObjectFile::eTypeDebugInfo);
          SymbolVendorELF *symbol_vendor = new SymbolVendorELF(module_sp);
          dsym_objfile_sp->GetSectionList(); ---> module_sp->GetSectionList();


https://reviews.llvm.org/D44157



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits