jingham added a comment.

I liked the fact that all these Argument input type string converters were all 
in one place, though arguably Args was not the right place.  Among other things 
it made it easy to see that if you were adding a new command that took in an 
Address, AddressToString was the canonical way to do it.  That's less obvious 
now that this one is a target function, and you would have to go look at 
another argument to see what it does.  I wonder if this problem isn't better 
solved by moving all the parsing functions somewhere more appropriate (like 
CommandInterpreter?) and then it isn't surprising what they might do.


lldb-commits mailing list

Reply via email to