xiaobai added subscribers: sas, xiaobai.
xiaobai added a comment.
I really like this idea! It will be very helpful for @sas and I. I'd like to +1
creating a separate `stats dump` subcommand instead of dumping stats on `stats
disable`.
================
Comment at: lldb/source/Commands/CommandObjectStats.cpp:37
+
+ if (target->GetCollectingStats() == true) {
+ result.AppendError("stats already enabled");
----------------
nit: You can drop the `== true`
================
Comment at: lldb/source/Commands/CommandObjectStats.cpp:88
+
+ if (target->GetCollectingStats() == false) {
+ result.AppendError("need to enable stats before disabling them");
----------------
nit:
```
if (!target->GetCollectingStats()) {
```
https://reviews.llvm.org/D45547
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
